Java recursion to find prime factors doesn't work -


i trying prime factors of number. for loop should work until finds match , should break , jump next if statement checks if number not equal zero.

public class factor {      public static arraylist <integer> holdnum = new arraylist();       public static void main(string[]args){         factor object = new factor();         object.factor(104);         system.out.println(holdnum.get(0));     }      public static int factor(int number){         int new_numb = 0;         int n=0;         for( n = 1; n < 9; n++) {                              if (number % n == 0) {                 holdnum.add(n);                 new_numb = number/n;                 break;                        }         }          system.out.println(new_numb);         if(new_numb < 0) {             holdnum.add(new_numb);             return 1;         } else {             return factor(new_numb);         }                         } }

there @ least 3 errors :

  • as okiharaherbst wrote, counter not incremented.
  • you start loop @ 1, yourval % 1 equals 0 , new_numb equals input val, you'll loop endlessly on 104.
  • new_numb never lesser 0.

Comments

Post a Comment

Popular posts from this blog

apache - Remove .php and add trailing slash in url using htaccess not loading css -

i have add following code htaccess file removing .php extension , add trailing slash urls. worked fine reduced page loading speed , css code not loading @ all. pages ugly. please help rewriteengine on rewritebase / ## hide .php extension snippet # externally redirect /dir/foo.php /dir/foo rewritecond %{the_request} ^[a-z]{3,}\s([^.]+)\.php [nc] rewriterule ^ %1/ [r,l] # add trailing slash rewritecond %{request_filename} !-f rewritecond %{request_uri} !/$ rewriterule . %{request_uri}/ [l,r=301] # internally forward /dir/foo /dir/foo.php rewritecond %{request_filename} !-d rewritecond %{request_filename}.php -f rewriterule ^(.*?)/?$ $1.php [l] we can rewrite urls using .htaccess files. before writing in .htaccess files need verify kind of server using. can check server adding a <?php phpinfo(); ?> in php page. ensure mod_rewrite module enabled in apache server. can identified checking phpinfo included page. common methods used url rewriting follows ...
Read more

javascript - jQuery show full size image on click -

pretty self explanatory not workking . i want display full image when user click on image... yes know there tons of plugins but i want keep simple. any idea ? css : .full { display: none; width: 500px; height: 500px; margin-left: 100px; margin-top: -300px; position: fixed; background-color: #f00; z-index: 6; } .thumbnail { width: 50px; height: 50px; } html: <img class="thumbnail" src="http://4.bp.blogspot.com/-uhbdp2esxng/txneptvi92i/aaaaaaaaaky/upfqis7zto0/s1600/rihanna-wallpaper.jpg"> jquery: $(document).ready(function() { $('.thumbnail').on('click', function() { var img = $('<img />',{src:this.src,'class':'full'}); $('.full').html(img).show(); console.log('done!'); }); }); try looking how jquery works. $(document).ready(function() { $('.thumbnail').on('click', function(...
Read more