php - PDO Multiple queries: commit and rollback transaction -


i need fire 2 queries. i'm doing this:

// begin transaction $this->db->begintransaction();  // fire queries if($query_one->execute()){     if($query_two->execute()){          // commit when both queries executed         $this->db->commit();     }else{         $this->db->rollback();    } }else{     $this->db->rollback(); }

is correct approach? i'm not using try..catch in code make code inappropriate or vulnerable situation?

yes, approach correct. using try...catch may lead cleaner , more readable code in cases overall approach fine.

if code fragment function handles db queries , not else, i'd switch approach around:

// begin transaction $this->db->begintransaction();  // fire queries if(!$query_one->execute()){     $this->db->rollback();     // other clean-up goes here     return; }  if(!$query_two->execute()){     $this->db->rollback();     // other clean-up goes here     return;  }  $this->db->commit();

of course, if require lots of clean-up done before can return, original approach better. in these cases i'd using pdo::errmode_exception. has additional benefits, exceptions automatically rolling transaction unless caught.


Comments

Post a Comment

Popular posts from this blog

apache - Remove .php and add trailing slash in url using htaccess not loading css -

i have add following code htaccess file removing .php extension , add trailing slash urls. worked fine reduced page loading speed , css code not loading @ all. pages ugly. please help rewriteengine on rewritebase / ## hide .php extension snippet # externally redirect /dir/foo.php /dir/foo rewritecond %{the_request} ^[a-z]{3,}\s([^.]+)\.php [nc] rewriterule ^ %1/ [r,l] # add trailing slash rewritecond %{request_filename} !-f rewritecond %{request_uri} !/$ rewriterule . %{request_uri}/ [l,r=301] # internally forward /dir/foo /dir/foo.php rewritecond %{request_filename} !-d rewritecond %{request_filename}.php -f rewriterule ^(.*?)/?$ $1.php [l] we can rewrite urls using .htaccess files. before writing in .htaccess files need verify kind of server using. can check server adding a <?php phpinfo(); ?> in php page. ensure mod_rewrite module enabled in apache server. can identified checking phpinfo included page. common methods used url rewriting follows ...
Read more

javascript - jQuery show full size image on click -

pretty self explanatory not workking . i want display full image when user click on image... yes know there tons of plugins but i want keep simple. any idea ? css : .full { display: none; width: 500px; height: 500px; margin-left: 100px; margin-top: -300px; position: fixed; background-color: #f00; z-index: 6; } .thumbnail { width: 50px; height: 50px; } html: <img class="thumbnail" src="http://4.bp.blogspot.com/-uhbdp2esxng/txneptvi92i/aaaaaaaaaky/upfqis7zto0/s1600/rihanna-wallpaper.jpg"> jquery: $(document).ready(function() { $('.thumbnail').on('click', function() { var img = $('<img />',{src:this.src,'class':'full'}); $('.full').html(img).show(); console.log('done!'); }); }); try looking how jquery works. $(document).ready(function() { $('.thumbnail').on('click', function(...
Read more