c - Simple stack, pop -


i looking simple stack implementation in c, , found that:

void pop(struct stack **top) {    struct stack *temp;    temp = malloc(sizeof(struct stack));    if(*top != null)    {        printf("%d popped.\n",(*top)->data);        temp = (*top);        (*top) = (*top)->prev;        free(temp);    }    else        printf("stack empty.\n"); }

probably it's newbie question i'm not sure i'm freeing free(temp). seems firstly i'm assigning current top temp, changing top top->next(previous top popped) , deleting temp. what's point of using temp?

or maybe written wrong?

the reason use temp because need remove top of stack (which popped), want modify top following element.

in order so, need store old top somewhere, change top, , remove last top.

the malloc() redundant , leaking memory, nothing it, bind temp, before using variable, rebind different address it.

as rule of thumb should hint there wrong - why need dynamic allocation in deletion? though not wrong, hint investigating.


Comments

Post a Comment

Popular posts from this blog

apache - Remove .php and add trailing slash in url using htaccess not loading css -

i have add following code htaccess file removing .php extension , add trailing slash urls. worked fine reduced page loading speed , css code not loading @ all. pages ugly. please help rewriteengine on rewritebase / ## hide .php extension snippet # externally redirect /dir/foo.php /dir/foo rewritecond %{the_request} ^[a-z]{3,}\s([^.]+)\.php [nc] rewriterule ^ %1/ [r,l] # add trailing slash rewritecond %{request_filename} !-f rewritecond %{request_uri} !/$ rewriterule . %{request_uri}/ [l,r=301] # internally forward /dir/foo /dir/foo.php rewritecond %{request_filename} !-d rewritecond %{request_filename}.php -f rewriterule ^(.*?)/?$ $1.php [l] we can rewrite urls using .htaccess files. before writing in .htaccess files need verify kind of server using. can check server adding a <?php phpinfo(); ?> in php page. ensure mod_rewrite module enabled in apache server. can identified checking phpinfo included page. common methods used url rewriting follows ...
Read more

javascript - jQuery show full size image on click -

pretty self explanatory not workking . i want display full image when user click on image... yes know there tons of plugins but i want keep simple. any idea ? css : .full { display: none; width: 500px; height: 500px; margin-left: 100px; margin-top: -300px; position: fixed; background-color: #f00; z-index: 6; } .thumbnail { width: 50px; height: 50px; } html: <img class="thumbnail" src="http://4.bp.blogspot.com/-uhbdp2esxng/txneptvi92i/aaaaaaaaaky/upfqis7zto0/s1600/rihanna-wallpaper.jpg"> jquery: $(document).ready(function() { $('.thumbnail').on('click', function() { var img = $('<img />',{src:this.src,'class':'full'}); $('.full').html(img).show(); console.log('done!'); }); }); try looking how jquery works. $(document).ready(function() { $('.thumbnail').on('click', function(...
Read more